Skip to content

Add Trimble position provider - #4641

Open
Withalion wants to merge 32 commits into
masterfrom
feature/trimble-provider
Open

Add Trimble position provider#4641
Withalion wants to merge 32 commits into
masterfrom
feature/trimble-provider

Conversation

@Withalion

@Withalion Withalion commented Aug 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

resolves https://github.com/MerginMaps/product/issues/121

For easier integration with Trimble external GNSS devices a new provider has been added. The setup has been essentially changed to be "one-click". Trimble Mobile Manager (TMM) companion app is required for proper setup.

New UI:

TODO:

  • Design is not decided yet
  • UK custom CRS might not work with elevation transformation

Testing criteria:

  • It's possible to add trimble external GNSS device
  • All information gets filled in GPS info Panel
  • It's possible to manage provider
  • It's not possible to change antenna height in the app, user should get redirected to TMM
  • Elevation transformation is supported
  • Geoid info is visible for both TMM provided height and transformed height
  • Custom CRS setup in TMM is supported
  • App tells you TMM is missing when it's missing

Withalion added 22 commits July 27, 2026 11:12
@Withalion
Squash and merge trimble prototype branch
136ccfe
@Withalion
Update gitignore
70a46ed
@Withalion
Refactor build system setup
8153aaf
@Withalion
Refactor trimble support context property in QML
fe3adca
@Withalion
Move trimble flag definition to config file
887abd7
@Withalion
Refactor bluetooth provider guard
b4ad426
@Withalion
Improve preprocessor guard resiliency
98224a4 
Some test cases with bluetooth preprocessor guard were not run, because
there was missing import for mmconfig.h
@Withalion
Update INSTALL.md
1924083
@Withalion
Refactor provider UI flow
340a1aa
@Withalion
Refactor registration flow
d4596fd
@Withalion
Refactor ReconnectDelay to abstractPositionProvider
8edfd98
@Withalion
Refactor Trimble position provider
2f2d03b 
Improve position data parsing, antenna height handling.
@Withalion
Fix Android trimble registration
8c01256
@Withalion
Fix websocket URL
8184350
@Withalion
Fix antenna height setup
a826041
@Withalion
Improve antenna height setting text
9ce3313
@Withalion
Refactor CRS from trimble provider & process geoid name
435f3ac
@Withalion
Sort TRIMBLE_REFERENCE_FRAMES
561d6f9
@Withalion
Update TRIMBLE_REFERENCE_FRAMES
28eb51e
@Withalion
Remove LSApplicationQueriesSchemes as it seems unnecessary
e7a4b3c
@Withalion
Merge branch 'master' into feature/trimble-provider
be81c7a
@Withalion
Fix antenna height value formatting for null value
355f2e0
@Withalion Withalion added this to the 2026.4.0 milestone Aug 9, 2026
@Withalion
Withalion requested a review from tomasMizera August 9, 2026 22:48
@Withalion Withalion self-assigned this Aug 9, 2026
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown

📦 Build Artifacts Ready

OS Status Build Info Workflow run
macOS Build ❌ Build failed or not found. #7150
linux Build ❌ Build failed or not found. #7176
win64 Build 📬 Mergin Maps 63521 win64 Expires: 09/11/2026 #6352
Android Build 📬 Mergin Maps 846111 APK [armeabi-v7a] Expires: 09/11/2026 #8461
📬 Mergin Maps 846111 APK [armeabi-v7a] Google Play Store #8461
Android Build 📬 Mergin Maps 846151 APK [arm64-v8a] Expires: 09/11/2026 #8461
📬 Mergin Maps 846151 APK [arm64-v8a] Google Play Store #8461
iOS Build 📬 Build number: 26.08.940211 #9402

@IvaKuklica

IvaKuklica commented Aug 12, 2026

Copy link
Copy Markdown

Testing Comments — Android (Trimble Mobile Manager integration)

  • 🧨 1. GPS connection status shows "connected" when Trimble receiver is not actually connected

  • When the user is NOT connected to the Trimble external GPS device (only the Trimble Mobile Manager app is open, with no device paired), the GPS info panel and the Manage GPS receiver screen both incorrectly show the status as "connected."

  • The app is not actually receiving data from the Trimble external GPS device in this state — only TMM itself is running. This is misleading, as it suggests an active GPS connection to the external receiver when none exists.

  • The connection status should reflect whether the external Trimble device itself is connected, not just whether TMM is open.

  • 2. Redirect to TMM on app launch
    When the app is opened, there's a brief redirect to TMM with a loading screen before Mergin Maps is displayed.

Screen_Recording_20260812_144154.mp4
  • 3. Satellites in use/view
    The number of satellites shown for both fields (in use/in view) stays the same, since there's only one value coming from TMM to display.
Screen_Recording_20260811_153349.2.mp4

@tomasMizera tomasMizera mentioned this pull request Aug 12, 2026
Open
@Withalion
Fix connection status & connection status drawer
5c5d307
@Withalion
Fix satellites values
cdbf4ef
@Withalion
Fix startup behaviour
fcf8dd2 
With trimble position provider after startup it looked like users
started Trimble app instead of MM. We add a bit of delay, so loading is more
natural.
@Withalion
Update comment
649d94e
@Withalion
Fix formatting
818876c
@Withalion
Fix test segfaults introduced with Trimble provider
bd89d05
@Withalion

Withalion commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator Author

Issues found in testing should be fixed now:

  1. After successful connection to TMM the status is "No data", after connecting to Trimble device the state should change between "Connecting", "Connected", "Disconnecting", "Disconnected". After the device is disconnected the data is not hidden.
  2. The app should not redirect to TMM right away on startup, it will wait until project is loaded. The issue was more noticeable if TMM was not running, if it was running there was no app switch.
  3. Issue has been fixed correct values are shown

@github-actions

github-actions Bot commented Aug 22, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 32565666835

Coverage increased (+0.5%) to 59.572%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 362 coverage regressions across 7 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

362 previously-covered lines in 7 files lost coverage.

File Lines Losing Coverage Coverage
mm/app/maptools/recordingmaptool.cpp 154 71.7%
mm/app/position/positionkit.cpp 105 60.0%
mm/app/main.cpp 83 36.22%
mm/app/position/geoposition.cpp 9 80.26%
mm/app/position/positiontransformer.cpp 8 83.62%
mm/app/appsettings.cpp 2 67.62%
mm/app/position/providers/simulatedpositionprovider.cpp 1 91.67%

Coverage Stats

Coverage Status
Relevant Lines: 15697
Covered Lines: 9351
Line Coverage: 59.57%
Coverage Strength: 94.38 hits per line
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasMizera tomasMizera Awaiting requested review from tomasMizera

Assignees

@Withalion Withalion

Labels

None yet

Projects

None yet

Milestone

2026.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Withalion @IvaKuklica